Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nil receiver on Properties #4198

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 19, 2024

Summary

Since all the providers that do not explicitly implement properties
interface return nil, nil, it might be a good idea to implement a nil
receiver for Properties.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Since all the providers that do not explicitly implement properties
interface return `nil, nil`, it might be a good idea to implement a nil
receiver for Properties.
@jhrozek jhrozek requested a review from a team as a code owner August 19, 2024 11:04
@coveralls
Copy link

Coverage Status

coverage: 53.892% (-0.007%) from 53.899%
when pulling 0c995bf on jhrozek:properties_nil_receive
into 02a42be on stacklok:main.

@JAORMX JAORMX merged commit 939e3d5 into mindersec:main Aug 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants