Add reference to central entities table in EEA #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a nullable reference to the central entities table in the EEA tables. This will simplify the EEA as we won't need to check multiple tables anymore. However, we can't just migrate to it in one go; we need to first duplicate the data then do it. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
eea-entity-instance-in
branch
from
9e357ca to
3d5d368
Compare
dmjb
reviewed
Aug 19, 2024
| ArtifactID: artifactID, | ||
| PullRequestID: pullRequestID, | ||
| ProjectID: projectID, | ||
| Entity: entities.EntityTypeToDB(inf.Type), |
There was a problem hiding this comment.
Do you plan to get rid of the type field in a future PR? (I know removing this requires a few steps to avoid breaking backwards compatibility)
There was a problem hiding this comment.
Right, type won't be needed in the future since the type won't matter. We'd be able to solely rely on the entity instance ID.
This PR merely duplicates info and is not making any logic moves yet.
jhrozek
approved these changes
Aug 19, 2024
| return uuid.Nil, fmt.Errorf("no entity ID found") | ||
| } | ||
|
|
||
| func (eiw *EntityInfoWrapper) getIDForEntityType(t minderv1.Entity) (uuid.UUID, bool) { |
There was a problem hiding this comment.
I guess you could make the methods simpler by making getIDForEntityType accept a nil receiver and return uuid.Nil in that case as well as not return the second bool from getIDForEntityType but just uuid.Nil. But it's a matter of taste, both are fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a nullable reference to the central entities table in the EEA
tables. This will simplify the EEA as we won't need to check multiple
tables anymore. However, we can't just migrate to it in one go; we need
to first duplicate the data then do it.
Closes: #4167
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: