Calculate profile status based on evaluation history tables #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
profile-status-trigger-eval-history
branch
2 times, most recently
from
c83df0c to
979eeae
Compare
dmjb
changed the title
dmjb
commented
Aug 14, 2024
| RAISE WARNING 'default case should not happen'; | ||
| END CASE; | ||
|
|
||
| -- This turned out to be very useful during debugging |
There was a problem hiding this comment.
This comment is copy-pasted from the previous trigger function, but I can testify that it was in fact very useful during debugging.
|
Changes unknown |
JAORMX
reviewed
Aug 15, 2024
| AND les.rule_entity_id = NEW.rule_entity_id; | ||
|
|
||
| IF v_new_status IS NULL THEN | ||
| RAISE EXCEPTION 'oh no'; |
There was a problem hiding this comment.
While this gave me a chuckle, perhaps we should use a more descriptive exception message?
There was a problem hiding this comment.
This was a debugging message I forgot to remove
Remove the existing triggers on rule_evaluations and rule_details_eval. Replace with triggers on latest_evaluation_statuses. Tweak the trigger logic to work on the new tables.
dmjb
force-pushed
the
profile-status-trigger-eval-history
branch
from
6678a1d to
ebd7f2b
Compare
dmjb
commented
Aug 15, 2024
| @@ -180,6 +181,61 @@ func upsertEvalStatus( | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func createRuleEntity( | |||
There was a problem hiding this comment.
All the changes in this test file are needed to use the evaluation history tables instead of the old rule evaluations tables when testing profile status transitions.
JAORMX
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the existing triggers on rule_evaluations and rule_details_eval.
Replace with triggers on latest_evaluation_statuses. Tweak the trigger
logic to work on the new tables.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: