Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address linter issues coming from govet #4138

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Address linter issues coming from govet #4138

merged 1 commit into from
Aug 14, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 14, 2024

Summary

The latest golangci-lint version is reporting issues, this PR fixes
them.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX
Address linter issues coming from govet
5823af8 
The latest golangci-lint version is reporting issues, this PR fixes
them.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner August 14, 2024 06:32
jhrozek
jhrozek approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more lint issue but that can be fixed in another PR

@JAORMX JAORMX merged commit 07b58e6 into main Aug 14, 2024
20 of 22 checks passed
@JAORMX JAORMX deleted the govet-lint branch August 14, 2024 07:20
dmjb pushed a commit that referenced this pull request Aug 14, 2024
@JAORMX @dmjb
Address linter issues coming from govet (#4138)
b24783c 
The latest golangci-lint version is reporting issues, this PR fixes
them.

Signed-off-by: Juan Antonio Osorio <[email protected]>
psekar pushed a commit to tinytrail/minder that referenced this pull request Aug 15, 2024
@JAORMX @psekar
Address linter issues coming from govet (mindersec#4138)
cf34d90 
The latest golangci-lint version is reporting issues, this PR fixes
them.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAORMX @jhrozek