Handle github repository transfer events. #4130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Github webhook events having type
repository
and actiontransferred
are handled by producing an internal event that triggers an evaluation. Despite being safe, it cannot lead to any useful action since the github app installation lost permissions to operate on the repository.This change makes it so that
repository.transferred
events are handled as deletions. In order for such deletion to be successful, 403 Forbidden errors on webhook deletions must be handled gracefully, so that repository deletion can terminate without errors.This is safe since (b) there's nothing Minder can do about this, having lost the necessary permissions, and (b) repository registration removes stale webhooks. The latter point is relevant to fix repository transfers when auto registration is enabled: in these cases, repository ownership is migrated before the event is delivered to Minder, making it impossible to cleanup webhooks, which leads to an SQL deletion failure, which eventually makes it impossibile to re-register the repository under the destination project.
Fixes #3274
Change Type
Testing
Unit and manually tested.
Review Checklist: