Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape quotes when retrieving selectors #4128

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

eleftherias
Copy link
Contributor

@eleftherias eleftherias commented Aug 13, 2024

Summary

Since we're writing a custom Scan, we need to unescape the double quotes when retrieving the selectors string from the DB.

Fixes #4122

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner August 13, 2024 11:42
@eleftherias eleftherias merged commit d4d29c2 into mindersec:main Aug 13, 2024
22 of 23 checks passed
@eleftherias eleftherias deleted the 4122-selector-quotes branch August 13, 2024 12:01
psekar pushed a commit to tinytrail/minder that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile selector strings are returned double quoted
2 participants