Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make go mock an explicit dependency in tools #4117

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Prior to this commit, the go mock dependency was implicitly added by the openFGA dependency.
The latest openFGA update removed the implicit dependency and caused our CI to fail (see https://github.com/stacklok/minder/actions/runs/10347230154/job/28637107802?pr=4112)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner August 12, 2024 09:31
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found no vulnerable dependencies.

Vulnerability scan of be6b712c:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@coveralls
Copy link

Coverage Status

coverage: 53.891% (-0.008%) from 53.899%
when pulling be6b712 on eleftherias:fix-tools-deps
into e438848 on stacklok:main.

@eleftherias eleftherias merged commit 2299d56 into mindersec:main Aug 12, 2024
21 of 22 checks passed
@eleftherias eleftherias deleted the fix-tools-deps branch August 12, 2024 09:43
psekar pushed a commit to tinytrail/minder that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants