Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unmanaged attributes in KC for local dev #4106

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Update Keycloak config in local docker image to allow for unmanaged attributes. Without this the attributes gh_id and gh_login weren't getting mapped into the token correctly, which was causing problems when looking up the user.

Fixes #4084

note: It is intentional that there's a JSON string in the YAML file. It would be nice if they offered a better configuration option, but this is the way to do it for now.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner August 8, 2024 07:51
@coveralls
Copy link

Coverage Status

coverage: 54.406% (+0.004%) from 54.402%
when pulling 790929f on eleftherias:4084-local-kc
into 2646d77 on stacklok:main.

@eleftherias eleftherias merged commit 7ac7423 into mindersec:main Aug 8, 2024
22 checks passed
@eleftherias eleftherias deleted the 4084-local-kc branch August 8, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bumping the keycloak version for local development
3 participants