Fix migrated column on rule evaluations #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After testing in staging, I found that the migration to set the `migrated` column did not work as expected. The intention was that any rows in `rule_evaluations` which have the same combination of rule instance ids and entity ids should be marked as migrated, as they refer to the same evaluations. This migration addresses this problem. Tested against staging (with a rollback)
eleftherias
approved these changes
Aug 7, 2024
dmjb
added a commit
that referenced
this pull request
Aug 7, 2024
After testing in staging, I found that the migration to set the `migrated` column did not work as expected. The intention was that any rows in `rule_evaluations` which have the same combination of rule instance ids and entity ids should be marked as migrated, as they refer to the same evaluations. This migration addresses this problem. Tested against staging (with a rollback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing in staging, I found that the migration to set the
migratedcolumn did not work as expected. The intention was that any rows inrule_evaluationswhich have the same combination of rule instance ids and entity ids should be marked as migrated, as they refer to the same evaluations. This migration addresses this problem.Tested against staging (with a rollback)
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: