-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of GitLab provider #4088
Conversation
d527792
to
75b9d01
Compare
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@@ -416,6 +417,18 @@ func getProvider(pstr string, token string, providerConfigFile string) (provifv1 | |||
return nil, fmt.Errorf("error instantiating dockerhub provider: %w", err) | |||
} | |||
|
|||
return client, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General thought (not a blocker for this PR) - this rttst.go
needs to get changed every time we touch providers, the executor, and various other things. I wonder if there's some way we can structure this to avoid needing to change it so often. (Obviously the big challenge is that needs to work without the database so it can't reuse a lot of the abstractions we have in the server)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the tricky side. Gotta give it some thought as we add more providers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Summary
This does a very minimal implementation of the gitlab provider.
It merely handles policy and enrollment. Which is progress. Note there is more to do to get this ready, but this is just the start. For safety, the gitlab provider is set behind a feature flag, so it cannot be enrolled.
Piggy backing on this, I also set the dockerhub provider to be behind a feature flag.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: