Drop rule_entity_id column from rule_evaluations

[dmjb]

This was added in a previous PR to simplify a PR. I have since decided on a simpler approach which uses a boolean migrated column instead of a FK reference. Using an FK reference ended up requiring some disruptive changes to some of our tests, so I decided to take the simpler approach instead.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

• Bug fix (resolves an issue without affecting existing features)
• Feature (adds new functionality without breaking changes)
• Breaking change (may impact existing functionalities or require documentation updates)
• Documentation (updates or additions to documentation)
• Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

• Reviewed my own code for quality and clarity.
• Added comments to complex or tricky code sections.
• Updated any affected documentation.
• Included tests that validate the fix or feature.
• Checked that related changes are merged.

[coveralls]

coverage: 54.365% (-0.007%) from 54.372%
when pulling 9042265 on populate-is-migrated-column
into 78138a2 on main.

[evankanderson]

LGTM

I'm assuming that you don't need or want to drop the constraint prior to dropping the rows that have that constraint?

I'm thinking if you did drop the constraint first, you might reduce the chance of large database locks going on during the delete.