Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change profile validation to enforce case insensitive unique rule names #4056

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Aug 1, 2024

Previously, minder required rule names to be unique within an entity type, but did so in a case-sensitive manner. Minder's API expects rule names to be unique in a case-insensitive manner. This changes the validation logic to prevent new rule instances from being created if they are not unique in a case insensitive manner.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Previously, minder required rule names to be unique within an entity
type, but did so in a case-sensitive manner. Minder's API expects rule
names to be unique in a case-insensitive manner. This changes the
validation logic to prevent new rule instances from being created if
they are not unique in a case insensitive manner.
@coveralls
Copy link

Coverage Status

coverage: 54.364% (-0.005%) from 54.369%
when pulling 234372a on validate-case-insensitive-names
into 66f213c on main.

@dmjb dmjb marked this pull request as ready for review August 1, 2024 13:09
@dmjb dmjb requested a review from a team as a code owner August 1, 2024 13:09
@dmjb dmjb merged commit 9c9d058 into main Aug 1, 2024
25 of 26 checks passed
@dmjb dmjb deleted the validate-case-insensitive-names branch August 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants