Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional DB migrations needed for evaluation history switchover #4055

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Aug 1, 2024

Adds:

  • Lower case index to rule instance names - this is needed since we will need the ability to query rule names in a case insensitive manner (see migration 31)
  • A "migrated" column to rule_evaluations. This will be used to figure out which entries in the rule_evaluations table need to be copied across to the evaluation_rule_entities table.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner August 1, 2024 08:54
@coveralls
Copy link

coveralls commented Aug 1, 2024

Coverage Status

coverage: 54.364% (-0.004%) from 54.368%
when pulling 3221c53 on more-eval-history-changes
into 9c9d058 on main.

@JAORMX
Copy link
Contributor

JAORMX commented Aug 1, 2024

Can you add ore context to both the title and PR description?

@dmjb dmjb changed the title More DB changes Additional DB migrations for evaluation history Aug 1, 2024
@dmjb dmjb changed the title Additional DB migrations for evaluation history Additional DB migrations needed for evaluation history switchover Aug 1, 2024
dmjb added 2 commits August 1, 2024 14:20
Adds:

* Lower case index to rule instance names
* A "migrated" column to rule_evaluations
@dmjb dmjb force-pushed the more-eval-history-changes branch from f68fe6a to 3221c53 Compare August 1, 2024 13:20
@dmjb dmjb merged commit 78138a2 into main Aug 1, 2024
22 checks passed
@dmjb dmjb deleted the more-eval-history-changes branch August 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants