Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the AWS SES migration to sdk v2 #4054

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix the AWS SES migration to sdk v2 #4054

merged 1 commit into from
Jul 31, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR fixes the migration we did to aws-sdk-go-v2 which caused the email sending service to stop working for minder.

Fixes #4045

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner July 31, 2024 12:30
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found no vulnerable dependencies.

Vulnerability scan of ffde81c6:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov rdimitrov merged commit 66f213c into main Jul 31, 2024
20 checks passed
@rdimitrov rdimitrov deleted the fix-mail branch July 31, 2024 12:38
@coveralls
Copy link

coveralls commented Jul 31, 2024

Coverage Status

coverage: 54.369% (-0.01%) from 54.383%
when pulling fe43dd1 on fix-mail
into 9ef39af on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to invite users
3 participants