Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate evaluation history tables with old evaluations #4052

Closed
wants to merge 3 commits into from

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 31, 2024

[NOTE: there is an issue with some of the unit tests which I am working through]

In order to replace the old rule status tables, we need to populate the evaluation history tables with the statuses of rule evaluations which happened prior to the introduction of the new tables. Once this migration is complete, it will be possible to change the existing profile and rule queries to use the evaluation history tables instead of the old rule evaluation/details tables.

Migration validated locally.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 31, 2024 11:54
dmjb added 3 commits July 31, 2024 14:03
In order to replace the old rule status tables, we need to populate the
evaluation history tables with the statuses of rule evaluations which
happened prior to the introduction of the new tables. Once this
migration is complete, it will be possible to change the existing
profile and rule queries to use the evaluation history tables instead of
the old rule evaluation/details tables.
@dmjb dmjb force-pushed the migrate-legacy-history branch from ae73fa1 to 0715fc3 Compare July 31, 2024 13:04
@dmjb dmjb marked this pull request as draft August 1, 2024 08:08
@dmjb
Copy link
Contributor Author

dmjb commented Aug 2, 2024

Replaced by #4065

@dmjb dmjb closed this Aug 2, 2024
@dmjb dmjb deleted the migrate-legacy-history branch August 2, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant