Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept filters multiple times in history list. #3978

Closed
blkt opened this issue Jul 24, 2024 · 0 comments · Fixed by #3979
Closed

Accept filters multiple times in history list. #3978

blkt opened this issue Jul 24, 2024 · 0 comments · Fixed by #3979
Assignees
@blkt
Labels
bug Something isn't working cli enhancement New feature or request

Comments

@blkt
Copy link
Contributor

blkt commented Jul 24, 2024

ListEvaluationHistory RPC accepts multiple entries for string-like filters, e.g. evaluation statuses, profile names, etc. While minder CLI internally manages those filters as slices, viper is not configured to accept repeated options.
@blkt blkt added bug Something isn't working cli enhancement New feature or request labels Jul 24, 2024
@blkt blkt self-assigned this Jul 24, 2024
blkt added a commit that referenced this issue Jul 24, 2024
@blkt
Accept filters multiple times in history list.
184c13f 
ListEvaluationHistory RPC accepts multiple entries for string-like
filters, e.g. evaluation statuses, profile names, etc. While minder
CLI internally manages those filters as slices, viper is not
configured to accept repeated options.

This change makes it possible to provide `--profile-name`,
`--entity-name`, `--entity-type`, `--eval-status`,
`--remediation-status`, and `--alert-status` options multiple times
with different values, all of which will eventually be passed to the
backend as filters.

Fixes #3978
@blkt blkt mentioned this issue Jul 24, 2024
Merged
10 tasks
@blkt blkt closed this as completed in f5629d9 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blkt blkt

Labels
bug Something isn't working cli enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept filters multiple times in history list. mindersec/minder
1 participant
@blkt