Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit hooks #63

Closed
wants to merge 1 commit into from
Closed

Conversation

jrottenberg
Copy link

Allow users to leverage tfupdate via pre-commit.

Integration with pre-commit
@minamijoyo
Copy link
Owner

@jrottenberg Thank you for your suggestion, but I prefer to keep a pull request for dependency changes made by tfupdate separate from other changes so that reviewers can easily confirm the changes. So I recommend users to use tfupdate in CI/CD pipeline and I don't encourage users to use tfupdate in a pre-commit hook.

Having said that, I understand there are various ways of thinking, it's ok that you use tfupdate in a pre-commit hook as you like, of course!
I guess the best place to share your configuration is: https://github.com/antonbabenko/pre-commit-terraform
Wouldn't it be better to share your configuration with people who like pre-commit hooks rather than putting it in this repository?

@jrottenberg
Copy link
Author

That's very nice, much appreciated.

All good I'll send the PR to Anton Babenko.

Thank you for a great project in the terraform ecosystem.

@jrottenberg
Copy link
Author

It has been merged in the pre-commit terraform repo 🎉

antonbabenko/pre-commit-terraform#342

Hopefully get more users adopting this great tool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants