TUI Freeze Fix - Add manually maintained hash to difficulty iterator #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyro
reviewed
Jan 5, 2022
phyro
reviewed
Jan 5, 2022
phyro
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
I can confirm this resolved my TUI freezing issue. Unfortunatelly, I'm still having issues syncing which seems unrelated to this change. Peers drop and everything starts working slowly for me. It might be due to some disk issues I'm experiencing that are unrelated to Grin, but will be able to tell only after I try on a different disk.
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 21, 2024
difficulty iterator (mimblewimble#3684) * add manually managed hash to difficulty iterator * text fix * fix for hash-of-hash, review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent performance optimisations to the difficulty iterator, a call to the chain's
get_header_by_heightneeded to be added. Unfortunately, this function relies on a read lock on the txhashset. A write lock is held unyielded for a very long time by validation code after the txhashset is downloaded, leading to a TUI freeze when calling this method.Fix is to avoid that call by re-adding a hash to the
HeaderDifficultyInfostruct, populated by maintaining hashes as provided in theprev_headerfield in the Headers themselves. This optionally keeps hashes available in theHeaderDifficultyInfostruct while still avoiding the need to deserialize the entire header to derive the hash.Note this point in the TUI code is the only place where a block's hash is needed from the DifficultyIterator, so impact should be minimal.