ignore error from set_read_timeout #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
set_read_timeout_error
branch
from
0e0ad61 to
b95645e
Compare
jaspervdm
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Can confirm that it no longer panics
20200225 20:53:07.996 DEBUG grin_p2p::conn - try_break: exit the loop: Connection(Custom { kind: UnexpectedEof, error: "failed to fill whole buffer" })
20200225 20:53:08.004 DEBUG grin_p2p::conn - Shutting down reader connection with ?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3242.
We do not actually care about the error when 0 is passed in as a timeout.
We do care about this throwing weird errors if the connection is disconnected when we attempt to set the timeout.