Account for the utxo rewind when attempting to fix a bad chain init #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
robust_chain_init
branch
from
d39cdc4 to
1bd5980
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a rudimentary "recovery" mechanism on chain init during startup.
We read the current chain head from the db, then check if the chain is valid at that point.
If not we "rewind" to the previous header, reset the chain head and try again.
The existing impl was not taking the UTXO set fully into consideration during this "rewind" and was simply resetting the head back to the previous header.
This PR fixes this and forces an explicit chain rewind via a txhashset extension. This will attempt to revert the UTXO set back to the correct state at the previous header before resetting the chain head.
This is still not perfect and will not "un-corrupt" a corrupted UTXO leafset but it should cover more edge cases and make chain init slightly more robust.