#2149: Resolve JSON RPC 2.0 non-compliance #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the JSON RPC requests and responses are not compliant with the spec as the server only accepts strings. This change is *non-breaking* as it simply adds the ability to understand integers as expected. Any old code continuing to only send string requests will continue to work as before.
|
Test would be beneficial for this PR not just to test the current impl but also to make sure that this case is not broken in the future |
|
Ordinarily, yes, but this was discussed in Keybase. If that doesn't satisfy, then feel free to add to the discussion. |
quentinlesceller
requested changes
Jan 28, 2020
There was a problem hiding this comment.
Hi @WhoNeedszZz, thank you for the PR :). Looking good 👍 . As mentioned by @hashmap above, tests would be beneficial here. I think a simple serialize/deserialize unit tests would probably do here. Thanks!
quentinlesceller
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Approved based on the fact that tests are currently being working on #3210. LGTM 🍾
quentinlesceller
added a commit
that referenced
this pull request
Jan 28, 2020
This reverts commit 1527802.
quentinlesceller
added a commit
that referenced
this pull request
Jan 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the JSON RPC requests and responses are not compliant with the spec as the server only accepts strings.
This change is non-breaking as it simply adds the ability to understand integers as expected.
Any old code continuing to only send string requests will continue to work as before.
Resolves #2149