Bug fix for highest_index in output API. #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified the issue and the proposed fix, I think what happened here is in the pre-3.0.0 version of the node API code there were some confusing mismatches between pmmr index and leaf index, and most of the code was changed to use pmmr index only. However, the newer version of the wallet doesn't call Thanks for catching and fixing this! Note this should also be cherry-picked into maintenance branches. |
yeastplume
approved these changes
Jan 20, 2020
quentinlesceller
added a commit
to quentinlesceller/grin
that referenced
this pull request
Jan 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for the following issue: #3199