Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic in TUI table selected item. focus is zero indexed #3169

Merged
merged 1 commit into from
Dec 12, 2019
Merged

fix: panic in TUI table selected item. focus is zero indexed #3169

merged 1 commit into from
Dec 12, 2019

Conversation

JosephGoulden
Copy link
Contributor

Additional fix for #3160
Focus is zero indexed so should not be equal to the length of rows.

@antiochp
Copy link
Member

This is actually important to fix now that we preserve the selected row (#3161).

thread 'main' panicked at 'index out of bounds: the len is 8 but the index is 8': /rustc/4560ea788cb760f0a34127156c78e2552949f734/src/libcore/slice/mod.rs:2717stack backtrace:

Now that the selection is preserved we can actually end up with the now-non-existent row selected without any user interaction.

antiochp
antiochp approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Will merge for beta.2.

@antiochp antiochp added this to the 3.0.0 milestone Dec 12, 2019
@antiochp antiochp merged commit 0fba087 into mimblewimble:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephGoulden @antiochp