Call zip_read() from within the txhashet lock for a consistent view on the files #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were taking a lock on the txhashet, rewinding and taking a snapshot (saving leafset to disk for specific header hash). Then releasing the txhashet lock and the copying the files and building the zip.
I do not see exactly how this could cause a corrupt
txhashset.zipbut it does risk all kinds of weird edge cases where we sync the txhashset files to disk (say from another thread processing a new block) in the period between releasing the lock and creating the zip.This PR moves the
txhashset::zip_read()call to inside the txhashet lock.Also added some logging to get an idea of when we create new zip files and when we reuse a previously created zip file.