fix: for TUI status try to acquire read lock on pmmr_header but if no… #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t available just leave the header stats alone
hashmap
approved these changes
Nov 14, 2019
hashmap
approved these changes
Nov 15, 2019
|
Some day we'll actually have useful read locks around some of this that actually allow validation to happen without blocking. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TUI status is currently broken when syncing the chain. It stops responding and does not show the percentage validation status of the txhashset. This is because during validation there is long lived write lock on pmmr_header. So when we try to get a read lock to update the status it blocks.
This fix adds a try_header_head() function which might return a Tip or not if the lock is not available right away. For TUI status this is okay as we can just update based on the available information and do not need to block.