optimize: avoid `insert` into `Vec`; use `into_iter` for less derefer… #3102

aurexav · 2019-10-29T10:31:31Z

avoid insert into Vec
use into_iter for less dereference

…ence

antiochp

👍

antiochp · 2019-10-29T14:33:43Z

core/src/core/pmmr/pmmr.rs

 		}
+		res.reverse();


Nice. Good catch. 👍

optimize: avoid insert into Vec; use into_iter for less derefer…

3d34913

…ence

antiochp approved these changes Oct 29, 2019

View reviewed changes

core/src/core/pmmr/pmmr.rs

}

res.reverse();

Copy link

Member

antiochp Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good catch. 👍

antiochp merged commit a39ff54 into mimblewimble:master Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize: avoid `insert` into `Vec`; use `into_iter` for less derefer… #3102

optimize: avoid `insert` into `Vec`; use `into_iter` for less derefer… #3102

aurexav commented Oct 29, 2019 •

edited

Loading

antiochp left a comment

antiochp Oct 29, 2019

optimize: avoid insert into Vec; use into_iter for less derefer… #3102

optimize: avoid insert into Vec; use into_iter for less derefer… #3102

Conversation

aurexav commented Oct 29, 2019 • edited Loading

antiochp left a comment

Choose a reason for hiding this comment

antiochp Oct 29, 2019

Choose a reason for hiding this comment

optimize: avoid `insert` into `Vec`; use `into_iter` for less derefer… #3102

optimize: avoid `insert` into `Vec`; use `into_iter` for less derefer… #3102

aurexav commented Oct 29, 2019 •

edited

Loading