Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmr simplified Chinese translation #3095

Merged
merged 8 commits into from
Oct 17, 2019
Merged

mmr simplified Chinese translation #3095

merged 8 commits into from
Oct 17, 2019

Conversation

aurexav
Copy link
Contributor

@aurexav aurexav commented Oct 14, 2019 •
edited
Loading

  • add simplified Chinese translation for mmr.md
  • add some missing star

Is the line 106 should be Taking its left child is subtracting 2^h. instead of the Taking its left sibling is subtracting 2^h.?

@quentinlesceller
Copy link
Member

Hi @AurevoirXavier. Thank you for the PR!

Is the line 106 should be Taking its left child is subtracting 2^h. instead of the Taking its left sibling is subtracting 2^h.?

Indeed it is! If you can fix in both docs (English and Chinese), that'd be great!

@aurexav
Copy link
Contributor Author

aurexav commented Oct 17, 2019

@quentinlesceller Done, :)

@quentinlesceller
Copy link
Member

Awesome. Merging!

@quentinlesceller quentinlesceller merged commit b4e42be into mimblewimble:master Oct 17, 2019
@aurexav aurexav deleted the mmr_Chinese_translation branch October 18, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurexav @quentinlesceller