-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update properties parameter type in alter_collection_properties … #2590
base: 2.5
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elijahxb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @elijahxb! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
/assign @czs007 |
#2566 fix type hint error |
The changes LGTM, I'll merge this PR once you fix the DCO error. Please sign-off this PR as the DCO robot suggests: https://github.com/milvus-io/pymilvus/pull/2590/checks?check_run_id=35983237075 |
@elijahxb Thank you for your contribution. The DCO can assist GitHub in better recognizing your identity and accurately tracking the number and details of your commits. The "signed off" in the DCO requires the addition of your primary GitHub email address. Here is my public email in github settings: To resolve the DCO issue, please refer to the following instructions: Additionally, you can directly open the corresponding page under the Details section of the DCO action to view the same instructions. |
email settings fixed. Please verify again,thank you |
fix typehint error.