Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine highlevel delete code comments #1778

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Refine highlevel delete code comments #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pymilvus/milvus_client/milvus_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def delete(
pks: Union[list, str, int],
timeout: Optional[float] = None,
**kwargs,
) -> List[Union[str, int]]:
):
"""Delete entries in the collection by their pk.

Delete all the entries based on the pk. If unsure of pk you can first query the collection
Expand All @@ -385,8 +385,8 @@ def delete(
This change is due to the large amount of data involved.
The delete interface no longer returns any results.
If no exceptions are thrown, it indicates a successful deletion.
However, for backward compatibility, If the primary_keys returned from Milvus is not empty
the list of primary keys is still returned.
However, for backward compatibility, If the primary_keys returned from old
Milvus(previous 2.3.2) is not empty, the list of primary keys is still returned.

Args:
pks (list, str, int): The pk's to delete. Depending on pk_field type it can be int
Expand Down