Skip to content

Commit

Permalink
Do not raise error if auto_id field is not provided
Browse files Browse the repository at this point in the history
  • Loading branch information
issamemari committed Jan 24, 2025
1 parent c5a3c18 commit 9aac43e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion pymilvus/client/entity_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def entity_to_field_data(entity: Any, field_info: Any, num_rows: int):
entity_value = entity.get("values")
valid_data = []

if field_info.get("nullable", False) or field_info.get("default_value", None):
if field_info.get("nullable", False) or field_info.get("default_value", None) or field_info.get("auto_id", False):
if len(entity_value) == 0:
valid_data = [False] * num_rows
else:
Expand Down
20 changes: 10 additions & 10 deletions pymilvus/client/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -460,14 +460,14 @@ def _parse_row_request(
)

if not enable_dynamic:
raise DataNotMatchException(
message=ExceptionsMessage.InsertUnexpectedField % k
)
raise DataNotMatchException(message=ExceptionsMessage.InsertUnexpectedField % k)

if k in fields_data:
field_info, field_data = field_info_map[k], fields_data[k]
if field_info.get("nullable", False) or field_info.get(
"default_value", None
if (
field_info.get("nullable", False)
or field_info.get("default_value", None)
or field_info.get("auto_id", False)
):
field_data.valid_data.append(v is not None)
entity_helper.pack_field_value_to_field_data(v, field_data, field_info)
Expand Down Expand Up @@ -542,14 +542,14 @@ def _parse_upsert_row_request(
)

if not enable_dynamic:
raise DataNotMatchException(
message=ExceptionsMessage.InsertUnexpectedField % k
)
raise DataNotMatchException(message=ExceptionsMessage.InsertUnexpectedField % k)

if k in fields_data:
field_info, field_data = field_info_map[k], fields_data[k]
if field_info.get("nullable", False) or field_info.get(
"default_value", None
if (
field_info.get("nullable", False)
or field_info.get("default_value", None)
or field_info.get("auto_id", False)
):
field_data.valid_data.append(v is not None)
entity_helper.pack_field_value_to_field_data(v, field_data, field_info)
Expand Down

0 comments on commit 9aac43e

Please sign in to comment.