delete: handle nested objects #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the implementation of `HclDeleter` to make it non-destructive. This is important for if / when wildcards are supported as we'll need to backtrack through the fields if the wildcard is not placed as the final part in the query.
This handles deletion from nested objects. Given the following terraform
file
```hcl
local {
obj = {
obj2 = {
val = 5
}
}
}
```
and the following delete query, `hq delete .local.obj.obj2.val`, the
previous behavior outputs:
```hcl
local {
obj = {}
}
```
The new behavior outputs:
```hcl
local {
obj = {
obj2 = {}
}
}
```
ryan-ph
force-pushed
the
ryanpham/delete/nested-object
branch
from
704c30a to
b3a4666
Compare
|
@ryan-ph wow, really nice work! |
|
released this in v0.19.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete: refactor iteration
This refactors the implementation of
HclDeleterto make itnon-destructive. This is important for if / when wildcards are supported
as we'll need to backtrack through the fields if the wildcard is not
placed as the final part in the query.
delete: handle nested objects
This handles deletion from nested objects. Given the following terraform
file
and the following delete query,
hq delete .local.obj.obj2.val, theprevious behavior outputs:
The new behavior outputs: