Fix PyPy and linux cross compilation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
commented
Mar 13, 2021
| maturin build -i python --release --out dist --no-sdist --target ${{ matrix.platform.target }} --manylinux ${{ matrix.platform.manylinux }} --cargo-extra-args="--no-default-features" --cargo-extra-args="--features=abi3,extension-module" # disable mimallocator | ||
| ' > build-wheel.sh | ||
|
|
||
| docker run --rm -v "$PWD":/io -w /io messense/manylinux2014-cross:${{ matrix.platform.arch }} bash build-wheel.sh |
There was a problem hiding this comment.
Using ubuntu-16.04 causing cannot allocate memory in static TLS block error when importing the built wheel which I believe is a issue with glibc. messense/manylinux2014-cross docker images use glibc 2.17 which is compliant with manylinux2014 on aarch64 and armv7l.
https://github.com/messense/pyrus-cramjam/runs/2101449199?check_suite_focus=true
messense
commented
Mar 13, 2021
| echo 'curl -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable | ||
| source ~/.cargo/env | ||
| rustup target add ${{ matrix.platform.target }} | ||
| maturin build -i python --release --out dist --no-sdist --target ${{ matrix.platform.target }} --manylinux ${{ matrix.platform.manylinux }} --cargo-extra-args="--no-default-features" --cargo-extra-args="--features=abi3,extension-module" # disable mimallocator |
There was a problem hiding this comment.
Had to disable mimalloctor because we don't have a C11 compatible C compiler in the docker container.
7 tasks
milesgranger
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The culprit is that
extension-modulefeature was disabled by accident.