Fix bytearray decompression #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
force-pushed
the
fix-bytearray-decompression
branch
from
e412d28 to
950e3f9
Compare
milesgranger
force-pushed
the
fix-bytearray-decompression
branch
from
950e3f9 to
15470d4
Compare
|
@martindurant Despite the benchmarks for bytearray now matching the slower speed of bytes; I'm going to merge this. Earlier this morning I was toying with a refactor that I think will get cramjam snappy performance numbers back below python-snappy. Thanks for reporting the issue and the update to the test! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #34
I was using decompress_len incorrectly; thus giving the wrong expected decompress length. 🤕
Updated the benchmarks to account for the new change. I'm sure there are performance improvements in there somewhere or moving forward. Will still get the good speed as before when using
output_lenhowever. 👍