Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry lockfile issues (and add pre-commit hook) #90

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jan 23, 2024

There can sometimes be errors with the poetry lockfile become out-of-sync with the pyproject.toml.

This PR adds a pre-commit hook to detect and prevent such errors.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6363e05) 52.49% compared to head (2f654b2) 60.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   52.49%   60.48%   +7.99%     
==========================================
  Files           9        9              
  Lines        1364     1364              
==========================================
+ Hits          716      825     +109     
+ Misses        648      539     -109     
Flag Coverage Δ
integrationtests ?
unittests 60.48% <ø> (+9.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyaog satyaog merged commit f49743d into mila-iqia:master Feb 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants