Fix dynamic versioning not working in the CI #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
satyaog
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the recent release, the package version was 0.0.0 in the GitHub CI:
https://github.com/mila-iqia/milatools/actions/runs/7572023233/job/20621010227#step:6:36
This is the same issue as in mtkennerly/poetry-dynamic-versioning#145
I made the release myself with
poetry publish --buildon my local machine, although in retrospect I probably shouldn't have done that.This PR is an attempt to fix the issue with the dynamic versioning in the GitHub CI so that the publishing it actually taken care of by GitHub Actions for the next release. I'm trying to do this by adapting the solution proposed in mtkennerly/poetry-dynamic-versioning#145 (comment) by installing the dynamic versioning plugin explicitly in the CI.
I find it surprising that doing
poetry installwouldn't also install the poetry plugins though 🤔