Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(only) add type hints #75

Merged
merged 3 commits into from
Dec 7, 2023
Merged

(only) add type hints #75

merged 3 commits into from
Dec 7, 2023

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Nov 13, 2023 •
edited
Loading

Add type annotations to the package, without changing anything about how the code works, or how it is tested.

This contains mostly the typing-related changes from #61

@lebrice lebrice marked this pull request as ready for review November 13, 2023 20:23
@lebrice lebrice mentioned this pull request Nov 13, 2023
Closed
@lebrice
Copy link
Collaborator Author

lebrice commented Nov 27, 2023 •
edited
Loading

NOTE: This PR broke a few tests because additional parameters are being passed to some functions.
I fixed the tests to reflect this, but until #77 is merged, it won't show up in the CI because these tests are not being run.
This PR will be therefore be rebased after #77 is merged.

@lebrice lebrice merged commit 4fc25c4 into mila-iqia:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breuleux breuleux breuleux approved these changes

@satyaog satyaog satyaog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lebrice @breuleux @satyaog