Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xfail on flaky test #138

Merged

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Dec 18, 2024

No description provided.

Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (4ffdbaa) to head (78f4562).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   74.21%   74.08%   -0.13%     
==========================================
  Files          17       17              
  Lines        2311     2311              
==========================================
- Hits         1715     1712       -3     
- Misses        596      599       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice merged commit 0872ed0 into mila-iqia:master Dec 18, 2024
16 checks passed
@lebrice lebrice deleted the fix-flaky-test_connect_with_node_name branch December 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants