-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of break lines, sub & superscripts as well as bold & italic styles #8
Conversation
…ext buffers to context
Could we get an option to make the styling stuff only run if you turn on a flag? Not sure how much stuff this would break if we put it in by default all the time. Maybe have an option for "style" just like the newlines code. |
I still need to setup few other things here. |
lib/vtext.js
Outdated
bolds: false, // Note: could also be turned on as new default | ||
italics: false, // Note: could also be turned on as new default | ||
subscripts: false, // Note: could also be turned on as new default | ||
superscripts: true // Note: superscripts used to be partly supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually didn't support superscripts in this module. Anyway, what do you think @mikolalysenko @etpinard about the default behaviour of styling tags? Should we keep all of them off? Or if you prefer to enable any or the rest by default?
@mikolalysenko |
Thanks @mikolalysenko for your review & the merge. |
Sorry, I forgot to publish to npm. My internet died while I was trying to
publish and I got distracted.
…On Sun, Nov 18, 2018 at 5:03 AM Mojtaba Samimi ***@***.***> wrote:
Thanks @mikolalysenko <https://github.com/mikolalysenko> for your review
& the merge.
Once I tried to bump & release a minor version; I noticed that I don't
have github & possibly npm permissions for this package.
I don't know if @bpostlethwaite <https://github.com/bpostlethwaite>
@etpinard <https://github.com/etpinard> could also help me with this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOJBk7EYe_29sWoSUF14p33ay5e69k6ks5uwHmrgaJpZM4YccMv>
.
|
Thanks @mikolalysenko for the new release. |
This PR enables the use of tags namely < b > < i > < sup > < sub> and < br > within webGL texts.
Please also refer to Plotly PR 3207 for user issues, examples & more information.
@mikolalysenko
@monfera