-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project update #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will cause problems with DNS changes.
The custom transport is not a nice to have.
Use defaultTaintNodeNotReadyName if not-ready-taint-name parameter is not specified. Build container from scratch. aws sdk update
@szuecs I've reverted the code in main.go and just disabled custom transport usage. |
The custom transport is required to make it work. There’s a client-go issue, that has to be solved before we can change this custom transport. Basically the fix is to rollout H2 within kubernetes client go and apiserver. Until it’s not done, we can not change this because of reliability. |
@@ -1,7 +1,5 @@ | |||
FROM registry.opensource.zalan.do/stups/alpine:latest | |||
MAINTAINER Team Teapot @ Zalando SE <[email protected]> | |||
FROM scratch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
It doesn’t help in your issue and it’s not possible to investigate from inside containers anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert this once we agree on final solution, cherry-picked and squashed in rush
That's the reason I've dropped custom transport completely.
Can you explain why? I'm open for better solution, altho this fix is currently working in my clusters w/o any problems so far. |
You will rarely see the problem, but dns is only looked up once in Go. If the ip changes you have to delete the pod manually, which at our scale can’t do. golang/go#23427 is the underlying Go issue and there’s also a kubernetes related client go issue kubernetes/client-go#374 (comment) which leads to kubernetes/kubernetes#65012 |
Tried to run this against kubernetes 1.12 but it complained about using custom transport.
Also included few tweaks.
Not sure if this project is still maintained?