Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow ignoring the classname attribute when calling resolveFileAndLine #1259

Merged

Conversation

ptsd
Copy link
Contributor

@ptsd ptsd commented Dec 3, 2024

Thanks for a useful action 👍

So the rust runner nextest has a junit quirk...

<testcase name="test_failure" classname="oxidized_navigation::parry3d">
    <failure type="test failure">thread &apos;test_failure&apos; panicked at tests/parry3d.rs:154:5:
assertion `left == right` failed: 0 must equal 1
  left: 0
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace</failure>

This results in all annotations ending up with a file of classname and a line number of 1.

image

Been a while since I wrote any TS, and have never dived into actions so feel free to suggest a better way.

  • Open to suggestions re: naming
  • Threading state like this feels yucky but seems to be idiomatic here 🤷

@mikepenz
Copy link
Owner

Thank you @ptsd for the contribution. I'll try to review as soon as possible.

…ileAndLine`. Fixes line number parsing for rust nextest junit output.
@mikepenz mikepenz force-pushed the feature/allow_ignore_classname_in_resolver branch from 42df462 to 66bb244 Compare December 13, 2024 12:05
- Run build & package
@mikepenz mikepenz force-pushed the feature/allow_ignore_classname_in_resolver branch from 66bb244 to 177df39 Compare December 13, 2024 12:12
@mikepenz mikepenz merged commit 731f74e into mikepenz:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants