Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons to convey information #1262

Closed
JayBazuzi opened this issue Dec 8, 2024 · 2 comments · Fixed by #1268
Closed

Change icons to convey information #1262

JayBazuzi opened this issue Dec 8, 2024 · 2 comments · Fixed by #1268
Labels

Comments

@JayBazuzi
Copy link

We love your test report so much that we spent our mob/ensemble session proposing ways we think could make it better.

Problem

Color draws my eye. In the following screenshot my eye is brought to the red Failed ❌, even though there are no failures.

image

Proposed Solution

Failing tests

Only show ❌ if there are failures:

image image

Skipped tests

  • Change the icon from ⏭️ to ⚠️

The yellow draws my eye more, and lets me know this is something that could be a problem. It is also more consistent with coloring of other test frameworks.

  • Only show skipped icon if there are skipped
image image

Passing tests

Communicate more information by adding an additional icon:

  • ✅: Everything passed with no failures
  • ☑️: Some tests passed and some tests failed
  • <No icon>: There were no passing tests.
image image image

Bonus - no tests run

If no tests run, use ❌. Notice how this compares to the last Passing tests example; we like this better.

image

Thanks,

@mikepenz
Copy link
Owner

Thank you very much @JayBazuzi and everyone else linked at the bottom for highlighting these changes.

Really appreciate the suggestions and I'll look into adopting parts (if not all) proposals.

@isidore
Copy link

isidore commented Dec 13, 2024

Thanks so much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants