Issue #377 : SkipQuery #1123
Merged
Issue #377 : SkipQuery #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great and congrats for this PR. Atleast you wrote the "SkipQuery" :) |
|
I didn't see the feature request #268... I think it would better if you reviewed that one first, since I'd have to change this code to match and use Fetch Row instead of Top. |
|
🚀 What an awesome PR. This one is really good. Thanks for enabling the SkipQuery feature. Thanks for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#377
Adding support for a SkipQuery API.
As for tests, I just copied/pasted the ones for BatchQuery and adapted the values to make them pass.