Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Test with node 4 and 5 on travis #24

Merged
merged 4 commits into from
Apr 27, 2016
Merged

Conversation

thangngoc89
Copy link
Contributor

No description provided.

@mikenikles
Copy link
Owner

@thangngoc89 Why would you like to specify node 4 and 5 instead of the latest stable release?

@simon-lifelike
Copy link

Travis CI is using nvm to manage node versions, and as per the nvm usage documentation:

  • stable: this alias is deprecated, and only truly applies to node v0.12 and earlier. Currently, this is an alias for node.

The version you want to test is probably 4, which covers the latest version of LTS, and node which covers the latest stable. Eventually additional aliases for LTS versions will be available.

@mikenikles
Copy link
Owner

Thanks @simon-lifelike! @thangngoc89 could you please merge the latest master into your branch so that I can resolve this PR? Cheers

@thangngoc89
Copy link
Contributor Author

I rebased this branch to your master

@coveralls
Copy link

coveralls commented Apr 27, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5c85068 on thangngoc89:patch-2 into a0cfb14 on mikenikles:master.

@thangngoc89
Copy link
Contributor Author

I added node 6 to build matrix.

@coveralls
Copy link

coveralls commented Apr 27, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 884e995 on thangngoc89:patch-2 into a0cfb14 on mikenikles:master.

@mikenikles
Copy link
Owner

@thangngoc89 Thanks so much, one last update from master and I'll be able to merge that PR.

@thangngoc89
Copy link
Contributor Author

PR updated.

@coveralls
Copy link

coveralls commented Apr 27, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 124b0d3 on thangngoc89:patch-2 into 97587cd on mikenikles:master.

@mikenikles
Copy link
Owner

Thanks!

@mikenikles mikenikles merged commit 23d0c44 into mikenikles:master Apr 27, 2016
@thangngoc89 thangngoc89 deleted the patch-2 branch April 27, 2016 07:03
@mikenikles mikenikles modified the milestone: v1.0.0 May 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants