chore: Replace string interpolation and dynamic property php8.2 deprecation #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-comvex
changed the title
|
looks good to me, please merge ✅ |
|
Still open, I made a duplicate PR for this #188 any plans to merge this and make a release? @anderson-comvex Btw, some properties have to be protected, private properties show errors: |
|
@vedmant I fixed your comment. |
|
This PR is generating clutter to me as it is not getting merged anytime soons, so i will close it, but feel free to pick the code to apply later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain:
Chore to remove the PHP8.2 Deprecation Warnings.
What changes did you make? (Give an overview)
${variable}{$variable}-Which issue (if any) does this pull request address?
No Opened Issues
Is there anything you'd like reviewers to focus on?
Not Specifically