fix notice Undefined index: operator #69
#193
Conversation
|
Tested as working for Laravel 5.7.14. Please merge in and address the tests as I guess they do not account for "InRaw" |
|
HI everyone, thanks for submitting this. I will take a look as soon as I can. At the moment I am very busy and can't promise I will get to it right away. |
|
A report for investigating is posted in #195 |
| @@ -97,7 +97,7 @@ protected function getQueryColumns(array $columns) : string | |||
|
|
|||
| protected function getTypeClause($where) : string | |||
| { | |||
| $type = in_array($where["type"], ["In", "NotIn", "Null", "NotNull", "between", "NotInSub", "InSub", "JsonContains"]) | |||
| $type = in_array($where["type"], ["InRaw", "In", "NotIn", "Null", "NotNull", "between", "NotInSub", "InSub", "JsonContains"]) | |||
There was a problem hiding this comment.
I think the other new types should be supported here too:
"InRaw", "NotInRaw", "IntegerInRaw", "IntegerNotInRaw"
And for completeness probably should be added to the array in getOtherClauses too.
There was a problem hiding this comment.
Will also need to get the tests written.
|
Working on implementing this now. |
|
@tegos @oliversarfas @stryaponoff @drbyte Could you guys provide eloquent queries that trigger each of the new types? I have been playing around with it, but so far my queries aren't triggering the new types. (Please reply here in form of comments.) |
|
@drbyte I wasn't able to find any references to the other types you mentioned above in the Laravel framework code. Also, I have been able to replicate the triggering the |
|
@mikebronner here are screenshots from the 5.7.13 to 5.7.14 diff I linked to:
|
|
@mikebronner BTW thanks for the speedy new release! |
No description provided.