Updated to ember-2.4 and beyond #23
Conversation
| @@ -37,7 +37,7 @@ prototype.activateRoute = function activateRoute(route) { | |||
|
|
|||
| prototype.routeFinishedSetup = function routeFinishedSetup(route) { | |||
| const endTime = t(); | |||
| const [r] = this.routes.filter(r => r.name === route.routeName); | |||
| const [r] = this.routes.filter((r) => r.name === route.routeName); | |||
There was a problem hiding this comment.
const shouldn't be used except in the module closure
I'm ok with this, but for compatibility reasons (maybe there's someone out there w/ a patched router, or an app that doesn't hit the bug), let's aim for generalized > 1.10 compatibility. Don't worry about addressing the 2.3 bug, except to:
|
|
Also thanks for all this work! Great to resurrect this addon from the ashes |
kiwiupover
force-pushed
the
updated-to-ember2.4
branch
4 times, most recently
from
080aa29 to
3caaf12
Compare
updated ember-try upgraded ember-cli updated tests to use components fixed test across 1.13 > 2.5 added ember try for 2.4 and 2.5
kiwiupover
force-pushed
the
updated-to-ember2.4
branch
from
3caaf12 to
b82ac3b
Compare
|
@mike-north This is ready again. I have updated the readme, found a typo in the components, pulled ember-perf-handlebars and made the CI much faster. Now I'm drinking coffee. Last thing I bumped the version number too |
|
@mike-north is there something else todo with this PR? |
|
Released as |
Happy JSCS
Upgraded ember-cli
Updated tests to use components
Added ember try for 1.11 -> 1.13 and 2.0, 2.1, 2.2,
2.3, 2.4 -> CanaryThis PR DROPS support for Ember 1.10 and below. Ember 2.3 has a bug in the router so this PR supports 2.4 through Canary interestingly Ember 2.0, 2.1 and 2.2 pass the tests so I could look into what the actual issues are in 2.3.
@mike-north I understand this is a big PR let me know if you want anything explained.
I will follow with a README update too.
Closes #19 #18