Skip to content

Commit

Permalink
Change import for NoopLogger
Browse files Browse the repository at this point in the history
It appears that OT removed the `NoopLogger` export from `core`:
open-telemetry/opentelemetry-js#1746

This prevents app crashes when a logger is not provided.
  • Loading branch information
mike-marcacci authored Jan 29, 2021
1 parent 10b37fb commit 5124268
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/opentelemetry-cloud-trace-exporter/src/trace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import {ExportResult, ExportResultCode, NoopLogger} from '@opentelemetry/core';
import {ExportResult, ExportResultCode} from '@opentelemetry/core';
import {ReadableSpan, SpanExporter} from '@opentelemetry/tracing';
import {Logger} from '@opentelemetry/api';
import {Logger, NoopLogger} from '@opentelemetry/api';
import * as protoloader from '@grpc/proto-loader';
import * as protofiles from 'google-proto-files';
import * as grpc from '@grpc/grpc-js';
Expand Down

0 comments on commit 5124268

Please sign in to comment.