#918: buffer for selected file paths too small on windows #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #918; the buffer lpstrFile stores the paths and file names of the selected files. As it turns out, 20 * 260 Bytes isn't enough when a user wants to select > 256 files. Changed the buffer size to 8192 * 260 Bytes (~2.1 MB) which, depending on the file path, is enough for picking > 2000 files. 8192 * 260 Bytes should fit at minimum 532,480 UTF16 characters. The memory profiler of Flutter DevTools shows no memory increase while the file picker dialog is open. Windows Task Manager shows a memory increase of 1 - 2 MB while the file picker dialog is opened.
miguelpruivo
approved these changes
Dec 16, 2021
miguelpruivo
deleted the
bug/buffer-for-selected-file-paths-too-small-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #918. With this change, it is possible to select at least 2300 files (even files with extra long file paths such as
C:\Users\phil\Downloads\abcdefghijklmnopqrstuvxyz0123456789\zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz.txt. Please see commit message for detailed explanation: 7450ae6