#871: file extensions not enforced on Windows #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the user could always select files without file extension (and files of the allowed type). Now, users can only select files that have a file extension and where the file extension is in the list of allowed file types.
miguelpruivo
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #871
Previously
Users could click on
All Files(*.*)in the bottom right dropdown even though a file filter was enabled:Now
Additional fixes
I improved the bug report template so that the checkboxes are always correctly rendered like this:
.
Previously, the default file type filters (
FileType.audio,FileType.image, etc.) weren't aligned on all three desktop platforms. I fixed it so that for exampleFileType.Audiofilters for*.aac,*.midi,*.mp3,*.ogg, and*.wavon all three platforms.There's one more bug under macOS which I wasn't able to fix (see TODO in
test/file_picker_macos_test.dart).