chore: fix unreachable switch default #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke-endare
force-pushed
the
fix_unreachble_switch_default
branch
from
83d1a1d to
ae4674b
Compare
| @@ -23,7 +23,7 @@ void main() { | |||
| expect( | |||
| dialogHandler.fileTypeToFileFilter(FileType.audio, null), | |||
| equals( | |||
| 'Audio File (*.[aA][aA][cC] *.[mM][iI][dD][iI] *.[mM][pP]3 *.[oO][gG][gG] *.[wW][aA][vV])'), | |||
| 'Audio File (*.[aA][aA][cC] *.[mM][iI][dD][iI] *.[mM][pP]3 *.[oO][gG][gG] *.[wW][aA][vV] *.[mM]4[aA])'), | |||
There was a problem hiding this comment.
This test was not updated in #1587
| @@ -22,7 +22,7 @@ void main() { | |||
| expect( | |||
| dialogHandler.fileTypeToFileFilter(FileType.audio, null), | |||
| equals( | |||
| 'Audio Files | *.[aA][aA][cC] *.[mM][iI][dD][iI] *.[mM][pP]3 *.[oO][gG][gG] *.[wW][aA][vV]'), | |||
| 'Audio Files | *.[aA][aA][cC] *.[mM][iI][dD][iI] *.[mM][pP]3 *.[oO][gG][gG] *.[wW][aA][vV] *.[mM]4[aA]'), | |||
There was a problem hiding this comment.
This test was not updated in #1587
| @@ -136,8 +136,6 @@ class FilePickerMacOS extends FilePicker { | |||
| return '"avi", "flv", "m4v", "mkv", "mov", "mp4", "mpeg", "webm", "wmv", "bmp", "gif", "jpeg", "jpg", "png"'; | |||
| case FileType.video: | |||
| return '"avi", "flv", "mkv", "mov", "mp4", "m4v", "mpeg", "webm", "wmv"'; | |||
| default: | |||
There was a problem hiding this comment.
| @@ -65,8 +65,6 @@ class KDialogHandler implements DialogHandler { | |||
| return 'Media File (${DialogHandler.toCaseInsensitive("*.avi *.flv *.mkv *.mov *.mp4 *.mpeg *.webm *.wmv *.bmp *.gif *.jpeg *.jpg *.png")})'; | |||
| case FileType.video: | |||
| return 'Video File (${DialogHandler.toCaseInsensitive("*.avi *.flv *.mkv *.mov *.mp4 *.mpeg *.webm *.wmv")})'; | |||
| default: | |||
There was a problem hiding this comment.
| @@ -57,8 +57,6 @@ class QarmaAndZenityHandler implements DialogHandler { | |||
| return "Media Files | ${DialogHandler.toCaseInsensitive('*.avi *.flv *.mkv *.mov *.mp4 *.mpeg *.webm *.wmv *.bmp *.gif *.jpeg *.jpg *.png')}"; | |||
| case FileType.video: | |||
| return "Video Files | ${DialogHandler.toCaseInsensitive('*.avi *.flv *.mkv *.mov *.mp4 *.mpeg *.webm *.wmv')}"; | |||
| default: | |||
There was a problem hiding this comment.
navaronbracke
approved these changes
Jan 29, 2025
| @@ -227,8 +227,6 @@ class FilePickerWindows extends FilePicker { | |||
| return 'Videos (*.avi,*.flv,*.mkv,*.mov,*.mp4,*.mpeg,*.webm,*.wmv)\x00*.avi;*.flv;*.mkv;*.mov;*.mp4;*.mpeg;*.webm;*.wmv\x00Images (*.bmp,*.gif,*.jpeg,*.jpg,*.png)\x00*.bmp;*.gif;*.jpeg;*.jpg;*.png\x00\x00'; | |||
| case FileType.video: | |||
| return 'Videos (*.avi,*.flv,*.mkv,*.mov,*.mp4,*.mpeg,*.webm,*.wmv)\x00*.avi;*.flv;*.mkv;*.mov;*.mp4;*.mpeg;*.webm;*.wmv\x00\x00'; | |||
| default: | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some failing checks due to https://dart.dev/tools/diagnostic-messages?utm_source=dartdev&utm_medium=redir&utm_id=diagcode&utm_content=unreachable_switch_default#unreachable_switch_default
The one in MacOS is fixed by #1690
This unblocks landing #1690